Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set verbose level of MG solver #615

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Set verbose level of MG solver #615

merged 2 commits into from
Nov 3, 2021

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Nov 3, 2021 •
edited
Loading 

hipace.MG_verbose = 0

0: (default) for no output
1: same output as before
2: print residuum for all MG iterations
3: same as 2
4: print information for each smoothing stepp

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

MaxThevenet
MaxThevenet reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I am not sure users appreciate the MG output... should the default be 0?

@AlexanderSinn
Copy link
Member Author

Yes that's better

@SeverinDiederichs
Copy link
Member

Lovely PR! I agree, let's put the default to 0, production runs produce a huge amount of output...

@AlexanderSinn
Copy link
Member Author

There is also a bottom_verbose option in amrex which is currently left at it's default value of 0. Should I expose this to the input script too?

@MaxThevenet
Copy link
Member

Do you know what it does?

@AlexanderSinn
Copy link
Member Author

Thousands of lines like this:

MLCGSolver_BiCGStab: Initial error (error0) =        2.503096765e-13
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0002537374651
MLCGSolver_BiCGStab: Iteration           1 rel. err. 5.209324614e-07
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 5.209324614e-07
MLCGSolver_BiCGStab: Initial error (error0) =        6.887944144e-15
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0003501088541
MLCGSolver_BiCGStab: Iteration           1 rel. err. 4.796799831e-07
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 4.796799831e-07
MLCGSolver_BiCGStab: Initial error (error0) =        1.952395385e-16
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0004617218165
MLCGSolver_BiCGStab: Iteration           1 rel. err. 7.714553882e-07
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 7.714553882e-07
MLCGSolver_BiCGStab: Initial error (error0) =        5.523504184e-18
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.000600729081
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.226785469e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.226785469e-06
MLCGSolver_BiCGStab: Initial error (error0) =        2.222473814e-10
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0002533723719
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.68565864e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.68565864e-06
MLCGSolver_BiCGStab: Initial error (error0) =        6.116219173e-12
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0003487471953
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.534522764e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.534522764e-06
MLCGSolver_BiCGStab: Initial error (error0) =        1.733668556e-13
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0004593413431
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.396454348e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.396454348e-06
MLCGSolver_BiCGStab: Initial error (error0) =        4.904724289e-15
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0005966491077
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.288128905e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.288128905e-06
MLCGSolver_BiCGStab: Initial error (error0) =        1.381619055e-16
MLCGSolver_BiCGStab: Half Iter           1 rel. err. 0.0007602899356
MLCGSolver_BiCGStab: Iteration           1 rel. err. 1.473630941e-06
MLCGSolver_BiCGStab: Final: Iteration    1 rel. err. 1.473630941e-06

@MaxThevenet
Copy link
Member

Then we can probably live without it for the moment, what do you think? But it's good to know we can get more output from the MG solver if needed.

@AlexanderSinn
Copy link
Member Author

I doesn’t seem to be particularly useful to me as well.

@MaxThevenet MaxThevenet merged commit b32544b into Hi-PACE:development Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSinn @SeverinDiederichs @MaxThevenet